Skip to content

Add a test to check if pruning of api keys is triggered #7290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bisgaard-itis merged 10 commits into from
Mar 4, 2025
Merged

Add a test to check if pruning of api keys is triggered #7290

bisgaard-itis merged 10 commits into from
Mar 4, 2025

Conversation

@bisgaard-itis
Copy link
Contributor

@bisgaard-itis bisgaard-itis commented Feb 27, 2025 •
edited
Loading

What do these changes do?

  • Add a test to check if pruning of api-keys is triggered.

Related issue/s

  • It was reported by Joel that there might be an issue with the pruning of the api keys. Hence, I add this test to check that the task for pruning api keys is actually triggered.
  • I double checked, that the pruning of api keys actually does work in a deployment. But now that I have this test I think it makes sense to add it.

How to test

Dev-ops checklist

@bisgaard-itis bisgaard-itis self-assigned this Feb 27, 2025
@bisgaard-itis bisgaard-itis added the a:webserver webserver's codebase. Assigning the area is particularly useful for bugs label Feb 27, 2025
@bisgaard-itis bisgaard-itis added this to the The Awakening milestone Feb 27, 2025
@codecov
Copy link

codecov bot commented Feb 27, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.40%. Comparing base (b7ac77b) to head (673d4d8).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #7290      +/-   ##
==========================================
- Coverage   87.12%   83.40%   -3.73%     
==========================================
  Files        1690      657    -1033     
  Lines       65633    31641   -33992     
  Branches     1121      168     -953     
==========================================
- Hits        57186    26389   -30797     
+ Misses       8127     5194    -2933     
+ Partials      320       58     -262
Flag Coverage Δ
integrationtests 64.98% <ø> (-0.41%) ⬇️
unittests 79.71% <ø> (-6.45%) ⬇️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 77.30% <ø> (-8.16%) ⬇️
agent ∅ <ø> (∅)
api_server ∅ <ø> (∅)
autoscaling ∅ <ø> (∅)
catalog ∅ <ø> (∅)
clusters_keeper ∅ <ø> (∅)
dask_sidecar ∅ <ø> (∅)
datcore_adapter ∅ <ø> (∅)
director ∅ <ø> (∅)
director_v2 79.09% <ø> (-12.22%) ⬇️
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 89.74% <ø> (ø)
efs_guardian ∅ <ø> (∅)
invitations ∅ <ø> (∅)
osparc_gateway_server ∅ <ø> (∅)
payments ∅ <ø> (∅)
resource_usage_tracker ∅ <ø> (∅)
storage ∅ <ø> (∅)
webclient ∅ <ø> (∅)
webserver 84.42% <ø> (-0.78%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7ac77b...673d4d8. Read the comment docs.

@bisgaard-itis bisgaard-itis marked this pull request as ready for review February 28, 2025 08:43
matusdrobuliak66
matusdrobuliak66 approved these changes Feb 28, 2025
View reviewed changes
Copy link
Collaborator

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

pcrespov
pcrespov approved these changes Feb 28, 2025
View reviewed changes
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx!
Left a couple of comments

GitHK
GitHK reviewed Feb 28, 2025
View reviewed changes
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please see my comment

@bisgaard-itis bisgaard-itis enabled auto-merge (squash) February 28, 2025 12:33
@bisgaard-itis bisgaard-itis requested a review from GitHK March 3, 2025 08:24
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 4, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@bisgaard-itis bisgaard-itis merged commit 27f40cc into ITISFoundation:master Mar 4, 2025
91 of 95 checks passed
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Mar 6, 2025
Closed
63 tasks
mrnicegyu11 pushed a commit to mrnicegyu11/osparc-simcore that referenced this pull request Mar 26, 2025
@bisgaard-itis @mrnicegyu11
Add a test to check if pruning of api keys is triggered (ITISFoundati…
6362c1b 
…on#7290)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GitHK GitHK GitHK approved these changes

@pcrespov pcrespov pcrespov approved these changes

@sanderegg sanderegg sanderegg approved these changes

@matusdrobuliak66 matusdrobuliak66 matusdrobuliak66 approved these changes

Assignees

@bisgaard-itis bisgaard-itis

Labels

a:webserver webserver's codebase. Assigning the area is particularly useful for bugs

Projects

None yet

Milestone

The Awakening

Development

Successfully merging this pull request may close these issues.

5 participants

@bisgaard-itis @GitHK @pcrespov @sanderegg @matusdrobuliak66